fix: Scope plan storage AWS credentials to prevent Atmos auth interference#93
Merged
Merged
Conversation
e08101f to
8bafd3f
Compare
Igor Rodionov (goruha)
approved these changes
Dec 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Use
output-credentials: truemode for plan storage credential configuration and pass credentials explicitly via step-levelenv:vars to the plan storage steps.Why
When using Atmos auth for Terraform operations (instead of the
terraform-apply-rolesetting), the AWS credentials configured for plan storage (S3/DynamoDB access) were persisting in environment variables and taking precedence over Atmos' authentication mechanism.This caused authentication failures when:
terraform-apply-rolewas not configured in gitops settingsAWS_ACCESS_KEY_ID,AWS_SECRET_ACCESS_KEY, andAWS_SESSION_TOKENChanges
output-credentials: trueto plan storage credential configuration stepplan-storage-credentialsfor referencing credential outputsenv:to "Retrieve Plan" and "Retrieve Lockfile" steps